Skip to content

fix: correctly handle novalidate attribute casing #15083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dummdidumm merged 4 commits into from
Jan 22, 2025
Merged

fix: correctly handle novalidate attribute casing #15083

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d09b865
Adding a test for `novalidate` attribute casing
Rican7 Jan 22, 2025
5f43ad8
Adding handling for `novalidate` attribute casing
Rican7 Jan 22, 2025
50106c0
Adding changeset
Rican7 Jan 22, 2025
304b613
Update packages/svelte/tests/runtime-runes/samples/form-novalidate-ca…
dummdidumm Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/pink-wolves-search.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: correctly handle `novalidate` attribute casing
3 changes: 2 additions & 1 deletion packages/svelte/src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,8 @@ const ATTRIBUTE_ALIASES = {
readonly: 'readOnly',
defaultvalue: 'defaultValue',
defaultchecked: 'defaultChecked',
srcobject: 'srcObject'
srcobject: 'srcObject',
novalidate: 'noValidate'
};

/**
Expand Down
8 changes: 8 additions & 0 deletions packages/svelte/tests/runtime-runes/samples/form-novalidate-casing/_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import { test } from '../../test';

export default test({
html: `
<form novalidate></form>
<form novalidate></form>
`
});
6 changes: 6 additions & 0 deletions packages/svelte/tests/runtime-runes/samples/form-novalidate-casing/main.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<script>
let noValidate = $state(true);
</script>

<form novalidate={true}></form>
<form {noValidate}></form>
Loading