Skip to content

fix: ensure resuming effects works correctly with unowned dependencies #15173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fix: ensure resuming effects works correctly with unowned dependencies #15173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
00a67be
fix: esnure resuming effects works correctly with unowned dependencies
trueadm Feb 1, 2025
300fc5b
fix: esnure resuming effects works correctly with unowned dependencies
trueadm Feb 1, 2025
f313637
fix: esnure resuming effects works correctly with unowned dependencies
trueadm Feb 1, 2025
bc9e575
fix: esnure resuming effects works correctly with unowned dependencies
trueadm Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-fans-beg.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: ensure resuming effects works correctly with unowned dependencies
16 changes: 12 additions & 4 deletions packages/svelte/src/internal/client/reactivity/effects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,10 +598,18 @@ function resume_children(effect, local) {
}

// If a dependency of this effect changed while it was paused,
// schedule the effect to update
if (check_dirtiness(effect)) {
set_signal_status(effect, DIRTY);
schedule_effect(effect);
// schedule the effect to update and ensure we set the effect
// to be the active reaction to ensure that unowned deriveds
// are correctly tracked because we're resuming the effect
var previous_reaction = active_reaction;
try {
set_active_reaction(effect);
if (check_dirtiness(effect)) {
set_signal_status(effect, DIRTY);
schedule_effect(effect);
}
} finally {
set_active_reaction(previous_reaction);
}

var child = effect.first;
Expand Down