Skip to content

fix: ignore typescript abstract methods during code transformation #15267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 12, 2025
+16 −0
Merged

fix: ignore typescript abstract methods during code transformation #15267

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9982d1b
fix: removing typescript abstract methods
caiquetorres Feb 11, 2025
f35dbcb
test
dummdidumm Feb 12, 2025
4723578
Update .changeset/short-fireants-talk.md
dummdidumm Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/short-fireants-talk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: removing typescript abstract methods
6 changes: 6 additions & 0 deletions packages/svelte/src/compiler/phases/1-parse/remove_typescript_nodes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,12 @@ const visitors = {
delete node.implements;
return context.next();
},
MethodDefinition(node, context) {
if (node.abstract) {
return b.empty;
}
return context.next();
},
VariableDeclaration(node, context) {
if (node.declare) {
return b.empty;
Expand Down
5 changes: 5 additions & 0 deletions packages/svelte/tests/runtime-runes/samples/typescript/main.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@

class MyClass implements Hello {}

abstract class MyAbstractClass {
abstract x(): void;
y() {}
}

declare const declared_const: number;
declare function declared_fn(): void;
declare class declared_class {
Expand Down