Skip to content

feat: Add closedby to HTMLDialogAttributes (dialog element) #15458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2025
Merged

feat: Add closedby to HTMLDialogAttributes (dialog element) #15458

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f7455c
Adding the `closedby` attribute to dialog element
Rican7 Mar 6, 2025
84fb0e7
Adding changeset
Rican7 Mar 6, 2025
d00f77b
Update .changeset/metal-spoons-scream.md
Rich-Harris Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/metal-spoons-scream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

feat: Add `closedby` property to HTMLDialogAttributes type
1 change: 1 addition & 0 deletions packages/svelte/elements.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,6 +957,7 @@ export interface HTMLDelAttributes extends HTMLAttributes<HTMLModElement> {

export interface HTMLDialogAttributes extends HTMLAttributes<HTMLDialogElement> {
open?: boolean | undefined | null;
closedby?: 'any' | 'closerequest' | 'none' | undefined | null;
}

export interface HTMLEmbedAttributes extends HTMLAttributes<HTMLEmbedElement> {
Expand Down