Skip to content

feat: make internal Svelte Custom Element treeshakable #16075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+13 −4
Closed

feat: make internal Svelte Custom Element treeshakable #16075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/warm-jokes-perform.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

Make internal Svelte Custom Element treeshakable
12 changes: 8 additions & 4 deletions packages/svelte/src/internal/client/dom/elements/custom-element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,12 @@ import { define_property, get_descriptor, object_keys } from '../../../shared/ut
* @property {'String'|'Boolean'|'Number'|'Array'|'Object'} [type]
*/

/** @type {any} */
let SvelteElement;
function get_svelte_element_class() {
if (typeof HTMLElement !== 'function') {
return;
}

if (typeof HTMLElement === 'function') {
SvelteElement = class extends HTMLElement {
return class extends HTMLElement {
/** The Svelte component constructor */
$$ctor;
/** Slots */
Expand Down Expand Up @@ -219,6 +220,9 @@ if (typeof HTMLElement === 'function') {
};
}

/** @type {any} */
const SvelteElement = /* @__PURE__ */ get_svelte_element_class();

/**
* @param {string} prop
* @param {any} value
Expand Down