Skip to content

feat: add command and commandfor to HTMLButtonAttributes #16117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

feat: add command and commandfor to HTMLButtonAttributes #16117

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bec7df8
feat: add `command` and `commandfor` to `HTMLButtonAttributes`
h4ckedneko Jun 9, 2025
7e79dc1
Update .changeset/empty-cherries-act.md
Rich-Harris Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/empty-cherries-act.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

feat: add `command` and `commandfor` to `HTMLButtonAttributes`
11 changes: 11 additions & 0 deletions packages/svelte/elements.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,6 +926,17 @@ export interface HTMLButtonAttributes extends HTMLAttributes<HTMLButtonElement>
value?: string | string[] | number | undefined | null;
popovertarget?: string | undefined | null;
popovertargetaction?: 'toggle' | 'show' | 'hide' | undefined | null;
command?:
| 'show-modal'
| 'close'
| 'request-close'
| 'show-popover'
| 'hide-popover'
| 'toggle-popover'
| (string & {})
| undefined
| null;
commandfor?: string | undefined | null;
}

export interface HTMLCanvasAttributes extends HTMLAttributes<HTMLCanvasElement> {
Expand Down