Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/unlucky-plants-jump.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: don't define `error.message` if it's not configurable
8 changes: 7 additions & 1 deletion packages/svelte/src/internal/client/error-handling.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { DEV } from 'esm-env';
import { FILENAME } from '../../constants.js';
import { is_firefox } from './dom/operations.js';
import { BOUNDARY_EFFECT, EFFECT_RAN } from './constants.js';
import { define_property } from '../shared/utils.js';
import { define_property, get_descriptor } from '../shared/utils.js';
import { active_effect } from './runtime.js';

/**
Expand Down Expand Up @@ -63,6 +63,12 @@ function adjust_error(error, effect) {
if (adjusted_errors.has(error)) return;
adjusted_errors.add(error);

const message_descriptor = get_descriptor(error, 'message');

// if the message was already changed and it's not configurable we can't change it
// or it will throw a different error swallowing the original error
if (message_descriptor && !message_descriptor.configurable) return;

var indent = is_firefox ? ' ' : '\t';
var component_stack = `\n${indent}in ${effect.fn?.name || '<unknown>'}`;
var context = effect.ctx;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import { test } from '../../test';

export default test({
compileOptions: {
dev: true
},
error: 'test'
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<script>
class CustomError extends Error {
constructor() {
super();
Object.defineProperty(this, "message", {
value: "test"
});
}
}
throw new CustomError()
</script>