Skip to content

fix: silence a11y warning for inert elements #16339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 14, 2025
Merged

fix: silence a11y warning for inert elements #16339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
01f386f
fix: silence a11y warning for inert elements
navorite Jul 11, 2025
b2113f2
changeset
navorite Jul 11, 2025
f3dd26b
merge main
Rich-Harris Jul 14, 2025
c6a8147
handle `inert=""`
Rich-Harris Jul 14, 2025
34c03c3
oops
Rich-Harris Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tall-avocados-repair.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: silence a11y warning for inert elements
5 changes: 4 additions & 1 deletion packages/svelte/src/compiler/phases/2-analyze/visitors/shared/a11y/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,10 @@ export function check_element(node, context) {
switch (node.name) {
case 'a':
case 'button': {
const is_hidden = get_static_value(attribute_map.get('aria-hidden')) === 'true';
const is_hidden =
get_static_value(attribute_map.get('aria-hidden')) === 'true' ||
get_static_value(attribute_map.get('inert')) !== null;

if (!has_spread && !is_hidden && !is_labelled && !has_content(node)) {
w.a11y_consider_explicit_label(node);
}
Expand Down
1 change: 1 addition & 0 deletions packages/svelte/tests/validator/samples/a11y-consider-explicit-label/input.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<a href="/#" aria-label="Valid empty link"></a>

<button aria-hidden='true'></button>
<button inert></button>
<a href="/#" aria-hidden='true'><b></b></a>

<button>Click me</button>
Expand Down
Loading