Skip to content

fix: do not defer unmount; immediately unmount components #16624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 15, 2025
Merged

fix: do not defer unmount; immediately unmount components #16624

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7f3a586
fix: do not defer unmount; immediately unmount components
harshmandan Aug 14, 2025
45ae96c
fix: add changeset
harshmandan Aug 14, 2025
d2c85f6
Update .changeset/few-geese-itch.md
dummdidumm Aug 15, 2025
b4cacab
add test
Rich-Harris Aug 15, 2025
4f5ac21
update changeset
Rich-Harris Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/few-geese-itch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': minor
---

Do not defer unmounting of component
10 changes: 5 additions & 5 deletions packages/svelte/src/internal/client/dom/blocks/svelte-component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,6 @@ export function component(node, get_component, render_fn) {
var pending_effect = null;

function commit() {
if (effect) {
pause_effect(effect);
effect = null;
}

if (offscreen_fragment) {
// remove the anchor
/** @type {Text} */ (offscreen_fragment.lastChild).remove();
Expand All @@ -56,6 +51,11 @@ export function component(node, get_component, render_fn) {

var defer = should_defer_append();

if (effect) {
pause_effect(effect);
effect = null;
}

if (component) {
var target = anchor;

Expand Down
Loading