Skip to content

fix: print(ast) types #17255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 2, 2025
+10 −7
Merged

fix: print(ast) types #17255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
793ee18
fix types?
manuel3108 Nov 26, 2025
797bbfa
fix types?
manuel3108 Nov 26, 2025
83206d9
fix types?
manuel3108 Nov 26, 2025
ce7927c
fix types?
manuel3108 Nov 26, 2025
c6235c0
revert stuff
manuel3108 Nov 29, 2025
fbeda1d
check fix?
manuel3108 Nov 30, 2025
4556598
comment
manuel3108 Nov 30, 2025
696c8a4
Merge remote-tracking branch 'origin/main' into fix/print-types
manuel3108 Nov 30, 2025
e0d4c78
fix types
manuel3108 Nov 30, 2025
14ed995
update esrap
manuel3108 Dec 1, 2025
59e32c9
Merge branch 'main' into fix/print-types
manuel3108 Dec 1, 2025
5942a38
esrap 2.2.1
benmccann Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/svelte/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@
"clsx": "^2.1.1",
"devalue": "^5.5.0",
"esm-env": "^1.2.1",
"esrap": "^2.2.0",
"esrap": "^2.2.1",
"is-reference": "^3.0.3",
"locate-character": "^3.0.0",
"magic-string": "^0.30.11",
Expand Down
3 changes: 2 additions & 1 deletion packages/svelte/src/compiler/print/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import ts from 'esrap/languages/ts';
import 'esrap'; // This import is required to make typescript happy when `skipLibCheck` is enabled
import type ts from 'esrap/languages/ts';

export type Options = {
getLeadingComments?: NonNullable<Parameters<typeof ts>[0]>['getLeadingComments'] | undefined;
Expand Down
2 changes: 2 additions & 0 deletions packages/svelte/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
/// <reference types="esrap" />

declare module 'svelte' {
/**
* @deprecated In Svelte 4, components are classes. In Svelte 5, they are functions.
Expand Down
10 changes: 5 additions & 5 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading