-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix: address reactivity glitches #6332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: address reactivity glitches #6332
Conversation
|
@subtle-byte it looks like this PR will need to be rebased |
|
@benmccann It is rebased now |
|
I think this needs a lot of testing and user feedback to verify whether it's what people would expect. If I write Thing is, I suspect there are probably use cases where that's absolutely the desired behavior, where you want to see both changes. And there are other use cases where you only want to see the change after the dependent store has finished updating. The question is how to accomodate both use cases, and that's why I think it's important to do a lot of testing and get user feedback before merging this PR, to make sure that this is what people would expect. |
| } | ||
| } | ||
| } else { | ||
| revalidate_writable(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect that this logic might be incorrect; I'll try to come up with proof (i.e., a use case where this ends up donig the wrong thing). Once I come up with an example, I'll put it in a REPL and link it here.
|
Closing Svelte 4 PRs as stale — thank you |
Fixes #6328
This PR just suggests an idea. Seems like it works, may be useful.
It was tested after applying #6331
Before submitting the PR, please make sure you do the following
Tests
npm testand lint the project withnpm run lint