Skip to content

Conversation

@ngtr6788
Copy link
Contributor

@ngtr6788 ngtr6788 commented May 26, 2023

"Successor" to #8442, fixes #6706 (because I closed it and deleted the branch)

This PR simplifies the solution done in the previous PR, up to date with version 4, and keeps most of the tests. However, I do not expect this PR to be merged, as per #8442, it is best to hold off until version 5. Therefore, this PR would be more of a reference for potential version 5 compiler output overhaul on how to solve this issue, so feel free to put this in One Day, I don't really mind.

HEADS UP: BIG RESTRUCTURING UNDERWAY

The Svelte repo is currently in the process of heavy restructuring for Svelte 4. After that, work on Svelte 5 will likely change a lot on the compiler aswell. For that reason, please don't open PRs that are large in scope, touch more than a couple of files etc. In other words, bug fixes are fine, but feature PRs will likely not be merged.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

@vercel
Copy link

vercel bot commented May 26, 2023

@ngtr6788 is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@ngtr6788 ngtr6788 marked this pull request as ready for review May 27, 2023 00:48
@benmccann benmccann deleted the branch sveltejs:svelte-4 June 20, 2023 20:45
@benmccann benmccann closed this Jun 20, 2023
@benmccann benmccann reopened this Jun 20, 2023
@benmccann benmccann changed the base branch from version-4 to master June 20, 2023 20:51
@changeset-bot
Copy link

changeset-bot bot commented Aug 6, 2023

⚠️ No Changeset found

Latest commit: 1677725

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ngtr6788
Copy link
Contributor Author

Will close this issue because of Svelte 5

@ngtr6788 ngtr6788 closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not implemented undefined (List of Nodes in handle)

2 participants