Skip to content

chore: unskip tests #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2024
Merged

chore: unskip tests #1022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/e2e-tests/import-queries/__tests__/__snapshots__/svelte-5/direct-css.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ button.svelte-d8vj6a {
color: #000099;
}

/*# sourceMappingURL=data:application/json;charset=utf-8;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiRHVtbXkuc3ZlbHRlIiwibWFwcGluZ3MiOiJBQVdrQiIsIm5hbWVzIjpbXSwic291cmNlcyI6WyJEdW1teS5zdmVsdGUiXX0= */
/*# sourceMappingURL=data:application/json;charset=utf-8;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiRHVtbXkuc3ZlbHRlIiwibWFwcGluZ3MiOiJBQVdrQiIsIm5hbWVzIjpbXSwiaWdub3JlTGlzdCI6W10sInNvdXJjZXMiOlsiRHVtbXkuc3ZlbHRlIl19 */
18 changes: 7 additions & 11 deletions packages/e2e-tests/import-queries/__tests__/__snapshots__/svelte-5/direct-js.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,19 @@ import * as $ from "/node_modules/.vite/deps/svelte_internal_client.js?v=XXX";
var root = $.template(`<button class="svelte-d8vj6a"> </button>`);

export default function Dummy($$anchor, $$props) {
let name = $.prop($$props, "name");
let clicks = $.mutable_source(0);
let name = $.prop($$props, "name", 8);
let clicks = $.mutable_state(0);
var button = root();
var text = $.child(button);

$.reset(button);
$.template_effect(() => $.set_text(text, `${name() ?? ""} clicks: ${$.get(clicks) ?? ""}`));

$.event(
"click",
button,
() => {
$.update(clicks);
},
false
);
$.event("click", button, () => {
$.update(clicks);
});

$.append($$anchor, button);
}

//# sourceMappingURL=data:application/json;charset=utf-8;base64,eyJ2ZXJzaW9uIjozLCJtYXBwaW5ncyI6Ijs7Ozs7O0tBQ1ksSUFBWTtLQUNuQixNQUFNLG9CQUFHLENBQUM7Ozs7NkNBTVYsSUFBSSwwQkFBVyxNQUFNIiwibmFtZXMiOltdLCJzb3VyY2VzIjpbIkR1bW15LnN2ZWx0ZSJdfQ==
//# sourceMappingURL=data:application/json;charset=utf-8;base64,eyJ2ZXJzaW9uIjozLCJtYXBwaW5ncyI6Ijs7Ozs7O0tBQ1ksSUFBWTtLQUNuQixNQUFNLG1CQUFHLENBQUM7Ozs7OzZDQU1WLElBQUksMEJBQVcsTUFBTTs7O1dBRHhCLE1BQU0iLCJuYW1lcyI6W10sImlnbm9yZUxpc3QiOltdLCJzb3VyY2VzIjpbIkR1bW15LnN2ZWx0ZSJdfQ==
23 changes: 12 additions & 11 deletions packages/e2e-tests/import-queries/__tests__/__snapshots__/svelte-5/ssr-custom-element.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,27 +3,28 @@ import * as $ from "svelte/internal/client";

var root = $.template(`<button class="svelte-d8vj6a"> </button>`);

const $$css = {
hash: "svelte-d8vj6a",
code: "button.svelte-d8vj6a {\n color: #000099;\n}"
};

export default function Dummy($$anchor, $$props) {
$.push($$props, false);
$.append_styles($$anchor, $$css);

let name = $.prop($$props, "name", 4);
let clicks = $.mutable_source(0);
let name = $.prop($$props, "name", 12);
let clicks = $.mutable_state(0);
var button = root();
var text = $.child(button);

$.reset(button);
$.template_effect(() => $.set_text(text, `${name() ?? ""} clicks: ${$.get(clicks) ?? ""}`));

$.event(
"click",
button,
() => {
$.update(clicks);
},
false
);
$.event("click", button, () => {
$.update(clicks);
});

$.append($$anchor, button);
$.append_styles($$anchor, "svelte-d8vj6a", "button.svelte-d8vj6a {\n color: #000099;\n}");

return $.pop({
get name() {
Expand Down
3 changes: 2 additions & 1 deletion packages/e2e-tests/import-queries/__tests__/__snapshots__/svelte-5/ssr-raw.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@
>

<style lang="scss">
@use 'sass:color';
$blue: blue;
button {
color: darken($blue, 20);
color: color.adjust($blue, $lightness: -20%);
}
</style>
16 changes: 6 additions & 10 deletions packages/e2e-tests/import-queries/__tests__/__snapshots__/svelte-5/ssr-script.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,17 @@ import * as $ from "svelte/internal/client";
var root = $.template(`<button class="svelte-d8vj6a"> </button>`);

export default function Dummy($$anchor, $$props) {
let name = $.prop($$props, "name");
let clicks = $.mutable_source(0);
let name = $.prop($$props, "name", 8);
let clicks = $.mutable_state(0);
var button = root();
var text = $.child(button);

$.reset(button);
$.template_effect(() => $.set_text(text, `${name() ?? ""} clicks: ${$.get(clicks) ?? ""}`));

$.event(
"click",
button,
() => {
$.update(clicks);
},
false
);
$.event("click", button, () => {
$.update(clicks);
});

$.append($$anchor, button);
}
4 changes: 2 additions & 2 deletions packages/e2e-tests/import-queries/__tests__/import-queries.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ describe('raw', () => {
});
});

describe.runIf(!isBuild).skip('direct', () => {
describe.runIf(!isBuild)('direct', () => {
test('Dummy.svelte?direct&svelte&type=style&sourcemap&lang.css', async () => {
const response = await fetchFromPage(
'src/Dummy.svelte?direct&svelte&type=style&sourcemap&lang.css',
Expand Down Expand Up @@ -114,7 +114,7 @@ describe.runIf(!isBuild).skip('direct', () => {
});
});

describe.runIf(!isBuild).skip('ssrLoadModule', () => {
describe.runIf(!isBuild)('ssrLoadModule', () => {
let vite: ViteDevServer;
let ssrLoadDummy;
beforeAll(async () => {
Expand Down
3 changes: 1 addition & 2 deletions packages/e2e-tests/inspector-kit/__tests__/inspector.kit.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { getEl, getText, isBuild, page, isCI } from '~utils';

// TODO reenable when inspector works for svelte5
describe.skip('inspector-kit', () => {
describe('inspector-kit', () => {
it('should render page', async () => {
expect(await getText('h1')).toBe('Hello Inspector!');
});
Expand Down
3 changes: 1 addition & 2 deletions packages/e2e-tests/inspector-vite/__tests__/inspector.vite.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { getEl, getText, isBuild, page, isCI } from '~utils';

// TODO reenable when inspector works for svelte5
describe.skip('inspector-vite', () => {
describe('inspector-vite', () => {
it('should render page', async () => {
expect(await getText('h1')).toBe('Hello Inspector!');
});
Expand Down