Skip to content

Conversation

dominikg
Copy link
Member

@dominikg dominikg commented Jul 3, 2025

for generating vite config ssr.noExternal

this improves it for people running into #1121

@AdrianGonz97
Copy link
Member

this is now working perfectly in the updated reproduction 🎉

@teemingc teemingc linked an issue Jul 4, 2025 that may be closed by this pull request
@teemingc
Copy link
Member

teemingc commented Jul 4, 2025

Is it worth adding a test for this with a setup similar to the reproduction?

@dominikg
Copy link
Member Author

dominikg commented Jul 4, 2025

Is it worth adding a test for this with a setup similar to the reproduction?

the crawling itself is tested in vitefu, we could try to add a a dependency that would be affected to e2e-tests/kit-node and expand this testcase

describe('resolved config', () => {

there are a couple of dependency shims in e2e-tests/test-dependencies, but i am not sure they match the requirements (must have a svelte library as devDependency that is also in the workspace), and we usually ref them in a way that is explicitly not a workspace ref (using file: protocol). @AdrianGonz97 do you have an idea of how to solve this (preferably without using public npm packages or at least ones that are already in the pnpm lock)

@dominikg
Copy link
Member Author

dominikg commented Jul 4, 2025

Is it worth adding a test for this with a setup similar to the reproduction?

turns out it was, found a windows path handling issue ❤️

@dominikg dominikg merged commit fac52a4 into main Jul 4, 2025
8 checks passed
@dominikg dominikg deleted the fix/crawl-workspace-devdeps branch July 4, 2025 13:02
This was referenced Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unprocessed .svelte files in transitive dependencies within a monorepo
3 participants