Skip to content

chore: skip extra typecheck when not rolldown-vite #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2025
Merged

chore: skip extra typecheck when not rolldown-vite #1160

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85fc2e7
chore: skip extra typecheck when not rolldown-vite
dominikg Jul 4, 2025
86c5aea
try again
dominikg Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,8 @@ jobs:
run: pnpm playwright install chromium
- name: run tests
run: pnpm test
- name: types
if: (${{ success() }} || ${{ failure() }})
- name: check-types with rolldown-vite
if: matrix.vite == 'rolldown-vite'
run: pnpm check:types
- name: archive tests temp directory
if: failure()
Expand Down