Skip to content

fix: do not wrongly suggest that a lang attribute is missing when finding comments #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

fix: do not wrongly suggest that a lang attribute is missing when finding comments #1166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fancy-guests-appear.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/vite-plugin-svelte': patch
---

skip comment blocks when reporting compiler errors that might be caused by a preprocessor issue
3 changes: 3 additions & 0 deletions packages/vite-plugin-svelte/src/utils/error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,9 @@ export function enhanceCompileError(err, originalCode, preprocessors) {

let m;
while ((m = styleRe.exec(originalCode))) {
if (m[0]?.startsWith('<!--')) {
continue;
}
// Warn missing lang attribute
if (!m[1]?.includes('lang=')) {
additionalMessages.push('Did you forget to add a lang attribute to your style tag?');
Expand Down