fix build --watch

.changeset/spotty-mirrors-pick.md

@@ -0,0 +1,5 @@
+---
+'@sveltejs/vite-plugin-svelte': patch
+---
+
+fix: ensure compiled svelte css is loaded correctly when rebuilding in `build --watch`

.gitignore

@@ -52,3 +52,5 @@ coverage
 packages/playground/**/*
 !packages/playground/README.md
 
+# vite plugin inspect
+.vite-inspect

.prettierrc.js

@@ -25,7 +25,8 @@ export default {
 				'**/vite.config.js.timestamp-*.mjs',
 				'packages/e2e-tests/dynamic-compile-options/src/components/A.svelte',
 				'packages/playground/big/src/pages/**', // lots of generated files
-				'packages/e2e-tests/scan-deps/src/Svelte*.svelte' // various syntax tests that require no format
+				'packages/e2e-tests/scan-deps/src/Svelte*.svelte', // various syntax tests that require no format
+				'**/.vite-inspect/**'
 			],
 			options: {
 				rangeEnd: 0

eslint.config.js

@@ -15,7 +15,8 @@ export default [
 			'packages/*/types/index.d.ts',
 			'packages/*/types/index.d.ts.map',
 			'packages/*/CHANGELOG.md',
-			'packages/e2e-tests/**/logs/**'
+			'packages/e2e-tests/**/logs/**',
+			'**/.vite-inspect/**'
 		]
 	},
 	...svelteOrgEslintConfig, // contains setup for svelte and typescript

package.json

@@ -3,10 +3,11 @@
   "private": true,
   "type": "module",
   "scripts": {
-    "test": "run-s -c test:unit \"test:build {@}\" \"test:serve {@}\" --",
+    "test": "run-s -c test:unit \"test:build {@}\" \"test:serve {@}\" \"test:build:watch {@}\" --",
     "test:unit": "vitest run",
     "test:serve": "vitest run -c vitest.config.e2e.ts",
     "test:build": "cross-env TEST_BUILD=1 vitest run -c vitest.config.e2e.ts",
+    "test:build:watch": "cross-env TEST_BUILD_WATCH=1 vitest run -c vitest.config.e2e.ts",
     "check": "run-p -c check:*",
     "check:audit": "pnpm audit --prod",
     "check:publint": "pnpm --filter \"./packages/*\" --parallel check:publint",
@@ -78,7 +79,8 @@
       "vite": "$vite",
       "@types/node@<=20.12.0": "20.19.9",
       "send@<0.19.0": "^0.19.1",
-      "@sveltejs/kit>cookie@<0.7.0": "^0.7.2"
+      "@sveltejs/kit>cookie@<0.7.0": "^0.7.2",
+      "vite-plugin-inspect": "/home/dominikg/develop/vite-plugin-inspect"
     },
     "onlyBuiltDependencies": [
       "esbuild"

packages/e2e-tests/_test_dependencies/vite-plugins/index.js

@@ -1,5 +1,15 @@
 import path from 'node:path';
 import fs from 'node:fs';
+import MagicString from 'magic-string';
+
+function replaceWithSourceMap(code, value, replacement) {
+	const s = new MagicString(code);
+	s.replaceAll(value, replacement);
+	return {
+		code: s.toString(),
+		map: s.generateMap({ hires: 'boundary' })
+	};
+}
 /**
  * Ensure transform flow is not interrupted
  * @returns {import('vite').Plugin[]}
@@ -11,19 +21,19 @@ export function transformValidation() {
 			enforce: 'pre',
 			transform(code, id) {
 				if (id.endsWith('.svelte')) {
-					return code.replaceAll('__JS_TRANSFORM_1__', '__JS_TRANSFORM_2__');
+					return replaceWithSourceMap(code, '__JS_TRANSFORM_1__', '__JS_TRANSFORM_2__');
 				} else if (id.endsWith('.css')) {
-					return code.replaceAll('__CSS_TRANSFORM_1__', '__CSS_TRANSFORM_2__');
+					return replaceWithSourceMap(code, '__CSS_TRANSFORM_1__', '__CSS_TRANSFORM_2__');
 				}
 			}
 		},
 		{
 			name: 'transform-validation:2',
 			transform(code, id) {
 				if (id.endsWith('.svelte')) {
-					return code.replaceAll('__JS_TRANSFORM_2__', '__JS_TRANSFORM_3__');
+					return replaceWithSourceMap(code, '__JS_TRANSFORM_2__', '__JS_TRANSFORM_3__');
 				} else if (id.endsWith('.css')) {
-					return code.replaceAll('__CSS_TRANSFORM_2__', 'red');
+					return replaceWithSourceMap(code, '__CSS_TRANSFORM_2__', 'red');
 				}
 			}
 		},
@@ -32,7 +42,7 @@ export function transformValidation() {
 			enforce: 'post',
 			transform(code, id) {
 				if (id.endsWith('.svelte')) {
-					return code.replaceAll('__JS_TRANSFORM_3__', 'Hello world');
+					return replaceWithSourceMap(code, '__JS_TRANSFORM_3__', 'Hello world');
 				}
 				// can't handle css here as in build, it would be `export default {}`
 			}

packages/e2e-tests/_test_dependencies/vite-plugins/package.json

@@ -6,5 +6,8 @@
   "main": "./index.js",
   "files": [
     "index.js"
-  ]
+  ],
+  "dependencies": {
+    "magic-string": "^0.30.17"
+  }
 }

packages/e2e-tests/build-watch/__tests__/build-watch.spec.ts

@@ -0,0 +1,157 @@
+import {
+	isBuildWatch,
+	getEl,
+	getText,
+	editFileAndWaitForBuildWatchComplete,
+	hmrCount,
+	untilMatches,
+	sleep,
+	getColor,
+	browserLogs,
+	e2eServer
+} from '~utils';
+
+import * as vite from 'vite';
+// @ts-ignore
+const isRolldownVite = !!vite.rolldownVersion;
+
+describe.runIf(isBuildWatch)('build-watch', () => {
+	test('should render App', async () => {
+		expect(await getText('#app-header')).toBe('Test-App');
+	});
+
+	test('should render static import', async () => {
+		expect(await getText('#static-import .label')).toBe('static-import');
+	});
+
+	test('should render dependency import', async () => {
+		expect(await getText('#dependency-import .label')).toBe('dependency-import');
+	});
+
+	test('should render dynamic import', async () => {
+		expect(await getEl('#dynamic-import')).toBe(null);
+		const dynamicImportButton = await getEl('#button-import-dynamic');
+		expect(dynamicImportButton).toBeDefined();
+		await dynamicImportButton.click();
+		await untilMatches(
+			() => getText('#dynamic-import .label'),
+			'dynamic-import',
+			'dynamic import loaded after click'
+		);
+	});
+
+	test('should not have failed requests', async () => {
+		browserLogs.forEach((msg) => {
+			expect(msg).not.toMatch('404');
+		});
+	});
+
+	test('should respect transforms', async () => {
+		expect(await getText('#js-transform')).toBe('Hello world');
+		expect(await getColor('#css-transform')).toBe('red');
+	});
+
+	describe('edit files', () => {
+		const updateHmrTest = editFileAndWaitForBuildWatchComplete.bind(
+			null,
+			'src/components/HmrTest.svelte'
+		);
+		const updateModuleContext = editFileAndWaitForBuildWatchComplete.bind(
+			null,
+			'src/components/partial-hmr/ModuleContext.svelte'
+		);
+		const updateApp = editFileAndWaitForBuildWatchComplete.bind(null, 'src/App.svelte');
+		const updateStore = editFileAndWaitForBuildWatchComplete.bind(null, 'src/stores/hmr-stores.js');
+
+		const getWatchErrors = () =>
+			isRolldownVite
+				? e2eServer.logs.watch.err.filter(
+						(m) =>
+							![
+								'Support for rolldown-vite in vite-plugin-svelte is experimental',
+								'See https://github.com/sveltejs/vite-plugin-svelte/issues/1143'
+							].some((s) => m.includes(s))
+					)
+				: e2eServer.logs.watch.err;
+
+		test('should have expected initial state', async () => {
+			// initial state, both counters 0, both labels red
+			expect(await getText('#hmr-test-1 .counter')).toBe('0');
+			expect(await getText('#hmr-test-2 .counter')).toBe('0');
+			expect(await getText('#hmr-test-1 .label')).toBe('hmr-test');
+			expect(await getText('#hmr-test-2 .label')).toBe('hmr-test');
+			expect(await getColor('#hmr-test-1 .label')).toBe('red');
+			expect(await getColor('#hmr-test-2 .label')).toBe('red');
+		});
+
+		test('should have working increment button', async () => {
+			// increment counter of one instance to have local state to verify after build updates
+			await (await getEl('#hmr-test-1 .increment')).click();
+			await sleep(50);
+
+			// counter1 = 1, counter2 = 0
+			expect(await getText('#hmr-test-1 .counter')).toBe('1');
+			expect(await getText('#hmr-test-2 .counter')).toBe('0');
+		});
+
+		test('should apply css changes in HmrTest.svelte', async () => {
+			// update style, change label color from red to green
+			await updateHmrTest((content) => content.replace('color: red', 'color: green'));
+
+			// color should have changed
+			expect(await getColor('#hmr-test-1 .label')).toBe('green');
+			expect(await getColor('#hmr-test-2 .label')).toBe('green');
+			expect(getWatchErrors(), 'error log of `build --watch` is not empty').toEqual([]);
+		});
+
+		test('should apply js change in HmrTest.svelte ', async () => {
+			// update script, change label value
+			await updateHmrTest((content) =>
+				content.replace("const label = 'hmr-test'", "const label = 'hmr-test-updated'")
+			);
+			expect(await getText('#hmr-test-1 .label')).toBe('hmr-test-updated');
+			expect(await getText('#hmr-test-2 .label')).toBe('hmr-test-updated');
+			expect(getWatchErrors(), 'error log of `build --watch` is not empty').toEqual([]);
+		});
+
+		test('should reset state of external store used by HmrTest.svelte when editing App.svelte', async () => {
+			// update App, add a new instance of HmrTest
+			await updateApp((content) =>
+				content.replace(
+					'<!-- HMR-TEMPLATE-INJECT -->',
+					'<HmrTest id="hmr-test-3"/>\n<!-- HMR-TEMPLATE-INJECT -->'
+				)
+			);
+			// counter state is reset
+			expect(await getText('#hmr-test-1 .counter')).toBe('0');
+			expect(await getText('#hmr-test-2 .counter')).toBe('0');
+			// a third instance has been added
+			expect(await getText('#hmr-test-3 .counter')).toBe('0');
+			expect(getWatchErrors(), 'error log of `build --watch` is not empty').toEqual([]);
+		});
+
+		test('should reset state of store when editing hmr-stores.js', async () => {
+			// change state
+			await (await getEl('#hmr-test-2 .increment')).click();
+			await sleep(50);
+			expect(await getText('#hmr-test-2 .counter')).toBe('1');
+			await updateStore((content) => `${content}\n/*trigger change*/\n`);
+			// counter state is reset
+			expect(await getText('#hmr-test-2 .counter')).toBe('0');
+			expect(getWatchErrors(), 'error log of `build --watch` is not empty').toEqual([]);
+		});
+
+		test('should work when editing script context="module"', async () => {
+			expect(await getText('#hmr-with-context')).toContain('x=0 y=1 slot=1');
+			expect(await getText('#hmr-without-context')).toContain('x=0 y=1 slot=');
+			expect(hmrCount('UsingNamed.svelte'), 'updates for UsingNamed.svelte').toBe(0);
+			expect(hmrCount('UsingDefault.svelte'), 'updates for UsingDefault.svelte').toBe(0);
+			await updateModuleContext((content) => content.replace('y = 1', 'y = 2'));
+			expect(await getText('#hmr-with-context')).toContain('x=0 y=2 slot=2');
+			expect(await getText('#hmr-without-context')).toContain('x=0 y=2 slot=');
+			expect(hmrCount('UsingNamed.svelte'), 'updates for UsingNamed.svelte').toBe(0);
+			expect(hmrCount('UsingDefault.svelte'), 'updates for UsingDefault.svelte').toBe(0);
+			expect(getWatchErrors(), 'error log of `build --watch` is not empty').toEqual([]);
+		});
+	});
+});

packages/e2e-tests/build-watch/index.html

@@ -0,0 +1,12 @@
+<!doctype html>
+<html lang="en">
+	<head>
+		<meta charset="UTF-8" />
+		<link rel="icon" href="/favicon.png" />
+		<meta name="viewport" content="width=device-width, initial-scale=1.0" />
+		<title>Svelte App</title>
+	</head>
+	<body>
+		<script type="module" src="/src/index.js"></script>
+	</body>
+</html>

packages/e2e-tests/build-watch/package.json

@@ -0,0 +1,23 @@
+{
+  "name": "e2e-tests-build-watch",
+  "private": true,
+  "version": "0.0.0",
+  "scripts": {
+    "dev": "vite dev",
+    "build": "vite build",
+    "build:watch": "vite build --watch",
+    "preview": "vite preview"
+  },
+  "dependencies": {
+    "e2e-test-dep-svelte-simple": "file:../_test_dependencies/svelte-simple"
+  },
+  "devDependencies": {
+    "@sveltejs/vite-plugin-svelte": "workspace:^",
+    "e2e-test-dep-vite-plugins": "file:../_test_dependencies/vite-plugins",
+    "node-fetch": "^3.3.2",
+    "svelte": "^5.36.13",
+    "vite": "^7.0.5",
+    "vite-plugin-inspect": "^11.3.2"
+  },
+  "type": "module"
+}

packages/e2e-tests/build-watch/src/App.svelte

@@ -0,0 +1,40 @@
+<script>
+	import StaticImport from './components/StaticImport.svelte';
+	import Dependency from 'e2e-test-dep-svelte-simple';
+	import HmrTest from './components/HmrTest.svelte';
+	import PartialHmr from './components/partial-hmr/PartialHmr.svelte';
+	const jsTransform = '__JS_TRANSFORM_1__';
+	let dynamicImportComponent;
+	function importDynamic() {
+		import('./components/DynamicImport.svelte').then((m) => (dynamicImportComponent = m.default));
+	}
+</script>
+
+<h1 id="app-header">Test-App</h1>
+<!-- to be transformed into "Hello world!" text -->
+<p id="js-transform">{jsTransform}</p>
+<!-- to be transformed into "hello-world" class -->
+<p id="css-transform">Hello world</p>
+<StaticImport />
+<Dependency />
+{#if !dynamicImportComponent}
+	<button id="button-import-dynamic" on:click={importDynamic}>import dynamic component</button>
+{:else}
+	<svelte:component this={dynamicImportComponent} />
+{/if}
+<HmrTest id="hmr-test-1" />
+<HmrTest id="hmr-test-2" />
+
+<!-- HMR-TEMPLATE-INJECT -->
+
+<PartialHmr />
+
+<style>
+	h1 {
+		color: #111111;
+	}
+
+	:global(#css-transform) {
+		color: __CSS_TRANSFORM_1__;
+	}
+</style>

packages/e2e-tests/build-watch/src/components/DynamicImport.svelte

@@ -0,0 +1,23 @@
+<script>
+	import asset from '/src/assets/dynamic.png';
+	const importedAsset = asset;
+	const label = 'dynamic-import';
+</script>
+
+<div id="dynamic-import">
+	<span class="label">{label}</span> <img alt="imported" src={importedAsset} />
+</div>
+
+<!-- HMR-TEMPLATE-INJECT -->
+<style>
+	.label {
+		padding-left: 2rem;
+		background-image: url('/src/assets/dynamic.png');
+		background-repeat: no-repeat;
+		background-size: contain;
+	}
+	img {
+		width: 1rem;
+		height: 1rem;
+	}
+</style>

packages/e2e-tests/build-watch/src/components/HmrTest.svelte

@@ -0,0 +1,21 @@
+<script>
+	import { getStore } from '../stores/hmr-stores';
+	export let id;
+	const count = getStore(id, 0);
+	const label = 'hmr-test';
+	function increment() {
+		$count++;
+	}
+</script>
+
+<div class="hmr-test" {id}>
+	<span class="label">{label}</span>
+	<button class="counter increment" on:click={increment}>{$count}</button>
+</div>
+
+<!-- HMR-TEMPLATE-INJECT -->
+<style>
+	.label {
+		color: red;
+	}
+</style>