Optional German holidays, descriptions#24
Open
tinne wants to merge 7 commits intosvendiedrichsen:masterfrom
Open
Optional German holidays, descriptions#24tinne wants to merge 7 commits intosvendiedrichsen:masterfrom
tinne wants to merge 7 commits intosvendiedrichsen:masterfrom
Conversation
Contributor
|
Will this get pulled into master? |
Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md) - [Commits](junit-team/junit4@r4.12...r4.13.1) Signed-off-by: dependabot[bot] <support@github.com>
Bump junit from 4.12 to 4.13.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As they are considered inofficial holidays in Germany under many circumstances, I suggest to add Christmas' eve and New Year's eve as unofficial holidays.
Also, I propose to use local naming for all descriptions in a file and provide a translation for the missing. Otherwise, all should be checked for English names (e.g. Bavarian, Nuremberg, Saxony, Northrhine-Westfalia, etc.).