Bugfix: should add extension, not index name#219
Open
Convincible wants to merge 1 commit intosverrirs:masterfrom
Open
Bugfix: should add extension, not index name#219Convincible wants to merge 1 commit intosverrirs:masterfrom
Convincible wants to merge 1 commit intosverrirs:masterfrom
Conversation
I believe this is a typo in the code, you mean to add the default extension when the url doesn't include a `.` i.e. is extensionless. This bug drove me mad for hours as the paginator refused to create clean files like `/news/2.html`, `/news/3.html`
|
Fixes #233 for me. I added it to the local gems and fixed it myself. Thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this is a typo in the code, you mean to add the default extension when the url doesn't include a
.i.e. is extensionless.This bug drove me mad for hours as the paginator refused to create clean files like
/news/2.html,/news/3.html