fix(convertPathData): use relSubpoint, not .coords#2157
Open
fix(convertPathData): use relSubpoint, not .coords#2157
Conversation
Collaborator
Author
|
the failing test cases are things like and the fail is because SVGO incorrectly rounds in a way that makes the start and end no longer connected and the incorrectly coded "convert going home to z" logic was the only thing stopping the failure from surfacing so fixing one thing shows another broken thing causes regressions... oh well i'll make a fix |
KTibow
changed the title
.coords is bad actually
folknor
added a commit
to folknor/svgo
that referenced
this pull request
Feb 18, 2026
- Handle consecutive t commands properly (svg#2156) svg#2156 - Use relSubpoint for accurate post-rounding coordinates (svg#2157) svg#2157 - Introduce isSafeToRemove for smarter stroke-linecap handling (svg#2164) svg#2164 Note: reverted svg#2157's z-removal change (relSubpoint is already reset to pathBase when z is processed, making the comparison always true). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it turns out in the past i used
item.coords(post-instruction coordinate in ORIGINAL svg) (resulting in incorrect calculations) when i should've been usingrelSubpoint; this switches torelSubpointwhen fitting.closes #2093