Skip to content

SpecularLighting param error #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcrossley wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SpecularLighting param error #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,9 +590,9 @@ new SVG.OffsetEffect(x, y);
[W3 doc](https://www.w3.org/TR/SVG/filters.html#feSpecularLightingElement)

```javascript
filter.specularLighting(surfaceScale, diffuseConstant, specularExponent, kernelUnitLength);
filter.specularLighting(surfaceScale, specularConstant, specularExponent, kernelUnitLength);
//or
new SVG.SpecularLightingEffect(surfaceScale, diffuseConstant, specularExponent, kernelUnitLength);
new SVG.SpecularLightingEffect(surfaceScale, specularConstant, specularExponent, kernelUnitLength);
```

***very complicated, just check out the W3 doc***
Expand Down
12 changes: 6 additions & 6 deletions src/svg.filter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@
return this.put(new SVG.DisplacementMapEffect(in1,in2,scale,xChannelSelector,yChannelSelector))
},
// SpecularLighting effect
specularLighting: function(surfaceScale,diffuseConstant,specularExponent,kernelUnitLength){
return this.put(new SVG.SpecularLightingEffect(surfaceScale,diffuseConstant,specularExponent,kernelUnitLength))
specularLighting: function(surfaceScale,specularConstant,specularExponent,kernelUnitLength){
return this.put(new SVG.SpecularLightingEffect(surfaceScale,specularConstant,specularExponent,kernelUnitLength))
},
// Tile effect
tile: function(){
Expand Down Expand Up @@ -248,8 +248,8 @@
return this.parent() && this.parent().displacementMap(this,in2,scale,xChannelSelector,yChannelSelector) //pass this as the first input
},
// SpecularLighting effect
specularLighting: function(surfaceScale,diffuseConstant,specularExponent,kernelUnitLength){
return this.parent() && this.parent().specularLighting(surfaceScale,diffuseConstant,specularExponent,kernelUnitLength).in(this)
specularLighting: function(surfaceScale,specularConstant,specularExponent,kernelUnitLength){
return this.parent() && this.parent().specularLighting(surfaceScale,specularConstant,specularExponent,kernelUnitLength).in(this)
},
// Tile effect
tile: function(){
Expand Down Expand Up @@ -426,10 +426,10 @@
kernelUnitLength: kernelUnitLength
})
},
specularLighting: function(surfaceScale,diffuseConstant,specularExponent,kernelUnitLength){
specularLighting: function(surfaceScale,specularConstant,specularExponent,kernelUnitLength){
this.attr({
surfaceScale: surfaceScale,
diffuseConstant: diffuseConstant,
specularConstant: specularConstant,
specularExponent: specularExponent,
kernelUnitLength: kernelUnitLength
})
Expand Down