Auto-include dump directory in symbol search path#41
Open
SSyl wants to merge 1 commit intosvnscha:mainfrom
Open
Auto-include dump directory in symbol search path#41SSyl wants to merge 1 commit intosvnscha:mainfrom
SSyl wants to merge 1 commit intosvnscha:mainfrom
Conversation
PDB files co-located with crash dumps were not found because the dump's directory was never added to CDB's symbol path. This caused degraded stack traces with wrong symbols and huge offsets (export symbols only). Changes: - Auto-prepend dump directory to symbol search path on session creation - Add --no-dump-dir-symbols CLI flag to opt out - Add per-call symbols_path parameter to open_windbg_dump and run_windbg_cmd - Return session-exists warning when symbols_path cannot be applied - Update tool descriptions to explicitly mention persistent sessions and that they should be closed when done. In practice, some LLMs would leave orphaned CDB processes running without this hint. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-yflag) so co-located PDBs are found automatically. This is on by default and matches standard debugging conventions.--no-dump-dir-symbolsCLI flag to opt out of the automatic behavior.symbols_pathparameter toopen_windbg_dumpandrun_windbg_cmdfor explicit symbol path control. Combined with the server-level default. Only applies when creating a new session — if a session already exists, a note is returned explaining this.Before
PDBs sitting next to the dump file were not found — stack traces showed wrong symbols with huge offsets (export symbols only):
After
Same dump, correct symbols loaded automatically from the dump's directory:
Test plan
open_windbg_dumploads co-located PDBs automatically (private pdb symbols)run_windbg_cmdloads co-located PDBs on demand when stack walking triggers symbol resolution--no-dump-dir-symbolsdisables the auto-include (falls back to export symbols only).sympathoutput shows dump directory prepended to symbol pathsymbols_pathis provided on an already-active session🤖 Generated with Claude Code