Open
Conversation
Owner
|
@landswellsong Why not use multicast 224.0.0.1 address instead of broadcast? It doesn't require any additional permissions |
Contributor
Author
|
@svpcom great alternative, didn't think of that. But I have options of some SW on an android tablet that's not aware of multicast, I'm not sure it can join the multicast group normally without too much rewrite. How about I add broadcasting as an option so it's only set if you explicitly mention it in the config? |
Owner
|
@landswellsong 224.0.0.1 multicast group is "local network" group and all hosts are members of it by default. It already used in wfb-ng video broadcasting example. |
svpcom
force-pushed
the
master
branch
11 times, most recently
from
7083c94 to
614f1f8
Compare
svpcom
force-pushed
the
master
branch
11 times, most recently
from
e3a877d to
b3a8884
Compare
svpcom
force-pushed
the
master
branch
2 times, most recently
from
e72d646 to
f8a805d
Compare
svpcom
force-pushed
the
master
branch
2 times, most recently
from
9bd67a2 to
cb114fd
Compare
svpcom
force-pushed
the
master
branch
2 times, most recently
from
b3416e1 to
46cc48c
Compare
svpcom
force-pushed
the
master
branch
7 times, most recently
from
aa12980 to
137e024
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Made this change for myself, but may be useful elsewhere. Allows to specify broadcast addresses for
connect://at rx side. Ideally we may want to check if the address is indeed a broadcast, butmavlink-routerdoesn't bother to do that so I'm not sure. Maybe it will fail if running as unprivileged user though.