Skip to content

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Dec 12, 2024

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

v1-v3 are deprecated and will soon be gone.

See failing job at https://github.com/swagger-api/swagger-codegen/actions/runs/12293381274/job/34305951479.

See documentation at https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/.

@fgreinacher
Copy link
Contributor Author

@frantuma Thanks for merging #12470.

Looks like we need this to get a green master again.

v1-v3 are deprecated and will soon be gone.
@fgreinacher
Copy link
Contributor Author

Not sure what's wrong with the LaceWork job: https://github.com/swagger-api/swagger-codegen/actions/runs/12297802252/job/34321626219?pr=12501. The error message is... not helpful/not existing :)

@frantuma frantuma merged commit 35e6141 into swagger-api:master Dec 13, 2024
10 of 11 checks passed
@fgreinacher
Copy link
Contributor Author

@frantuma Thanks for merging This has worked well: https://github.com/swagger-api/swagger-codegen/actions/runs/12319833041

If you could produce a new release for this that would be an awesome early Christmas present :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants