Skip to content

feat: prevent path traversal attacks in Generator class(#12611) #12620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
+2 −4
Merged

feat: prevent path traversal attacks in Generator class(#12611) #12620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions modules/swagger-generator/src/main/java/io/swagger/generator/online/Generator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ private static String generate(String language, GeneratorInput opts, Type type)
if (destPath == null) {
destPath = language + "-" + type.getTypeName();
}
SecureFileUtils.validatePath(destPath);

ClientOptInput clientOptInput = new ClientOptInput();
ClientOpts clientOpts = new ClientOpts();
Expand All @@ -147,7 +148,6 @@ private static String generate(String language, GeneratorInput opts, Type type)
if (files.size() > 0) {
List<File> filesToAdd = new ArrayList<File>();
LOGGER.debug("adding to " + outputFolder);
SecureFileUtils.validatePath(outputFolder);
filesToAdd.add(new File(outputFolder));
ZipUtil zip = new ZipUtil();
zip.compressFiles(filesToAdd, outputFilename);
Expand All @@ -164,7 +164,6 @@ private static String generate(String language, GeneratorInput opts, Type type)
}
}
try {
SecureFileUtils.validatePath(outputFilename);
new File(outputFolder).delete();
} catch (Exception e) {
LOGGER.error("unable to delete output folder " + outputFolder);
Expand Down
3 changes: 1 addition & 2 deletions modules/swagger-generator/src/test/java/io/swagger/generator/online/GeneratorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package io.swagger.generator.online;

import io.swagger.generator.exception.BadRequestException;
import org.testng.annotations.Test;
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
Expand All @@ -14,7 +13,7 @@
*/
public class GeneratorTest {

@Test(expectedExceptions = BadRequestException.class)
@Test(expectedExceptions = SecurityException.class)
public void testGenerateWithPathTraversalInOutputFolder() throws Exception {
io.swagger.generator.model.GeneratorInput opts = new io.swagger.generator.model.GeneratorInput();

Expand Down
Loading