Skip to content

chore: remove System.out and printStackTrace to align with Sonar rules S106 and S1148 #4988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 10, 2025
Merged

chore: remove System.out and printStackTrace to align with Sonar rules S106 and S1148 #4988

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8fcecf9
chore: replace System.out/printStackTrace with logging
kuntal1461 Oct 7, 2025
686949f
by kuntal : replace System.out and printStackTrace with SLF4J logging…
kuntal1461 Oct 8, 2025
3cec83f
chore: remove System.out and printStackTrace to align with Sonar rule…
kuntal1461 Oct 9, 2025
d5e529d
chore: remove System.out and printStackTrace to align with Sonar rule…
kuntal1461 Oct 9, 2025
92a3300
chore: remove System.out and printStackTrace to align with Sonar rule…
kuntal1461 Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ...e-transformer-maven-plugin/src/main/java/io/swagger/v3/oas/transformer/TransformMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ public class TransformMojo extends AbstractMojo {
@Parameter(defaultValue = "transformed")
private String classifier;

@Parameter(property = "transformer-plugin.max-log-buffer-size", defaultValue = "16384")
private int maxLogBufferSize;

@Parameter(defaultValue = "${project.build.directory}", required = true)
private File outputDirectory;

Expand Down Expand Up @@ -188,7 +191,7 @@ private Map<Transformer.AppOption, String> getOptionDefaults() {

private PrintStream createLoggingPrintStream(Consumer<String> logConsumer) {
try {
return new PrintStream(new LoggingOutputStream(logConsumer), true, StandardCharsets.UTF_8.name());
return new PrintStream(new LoggingOutputStream(logConsumer, maxLogBufferSize), true, StandardCharsets.UTF_8.name());
} catch (UnsupportedEncodingException e) {
throw new IllegalStateException("UTF-8 encoding is not supported", e);
}
Expand All @@ -197,9 +200,11 @@ private PrintStream createLoggingPrintStream(Consumer<String> logConsumer) {
private static final class LoggingOutputStream extends OutputStream {
private final Consumer<String> logConsumer;
private final ByteArrayOutputStream buffer = new ByteArrayOutputStream();
private final int maxBufferSize;

private LoggingOutputStream(Consumer<String> logConsumer) {
private LoggingOutputStream(Consumer<String> logConsumer, int maxBufferSize) {
this.logConsumer = logConsumer;
this.maxBufferSize = maxBufferSize > 0 ? maxBufferSize : Integer.MAX_VALUE;
}

@Override
Expand All @@ -208,6 +213,9 @@ public void write(int b) {
flushBuffer();
} else if (b != '\r') {
buffer.write(b);
if (buffer.size() >= this.maxBufferSize) {
flushBuffer();
}
}
}

Expand Down
Loading