allOf with multiple schemas adds additional square bracks in example#378
Open
richard-walsh-sb wants to merge 6 commits intoswagger-api:masterfrom
Open
allOf with multiple schemas adds additional square bracks in example#378richard-walsh-sb wants to merge 6 commits intoswagger-api:masterfrom
richard-walsh-sb wants to merge 6 commits intoswagger-api:masterfrom
Conversation
…ts are added around the resulting example
# Conflicts: # src/test/java/io/swagger/oas/test/examples/ExampleBuilderTest.java
gracekarina
reviewed
Feb 16, 2021
Contributor
There was a problem hiding this comment.
Hi @richard-walsh-sb, I suggest to use the option resolveCombinators set to false.
Like this:
ParseOptions options = new ParseOptions();
options.setResolve(true);
options.setResolveFully(true);
options.setResolveCombinators(false);
I have tested locally and the example is generated without the extra bracks.
The ComposedSchema won’t be merged into one though, but the example will generate fine. Do you need the composedSchema merged into one new Schema?
Contributor
|
@richard-walsh-sb, I tried a different solution and this is the outcome: Will this work ? or pagination needs to be on a diferent node? |
…ctor into bug/multipleAllOf
mea culpa, fix bad example
…sb/swagger-inflector into bug/multipleAllOf
9d6fa76 to
6c0c54d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.