Merge pull request #894 from saileshsingh/bugFix2

Fix for issue 892

Author: gracekarina

modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/util/OpenAPIDeserializer.java

@@ -524,6 +524,9 @@ public Paths getPaths(ObjectNode obj, String location, ParseResult result) {
                 if (!pathValue.getNodeType().equals(JsonNodeType.OBJECT)) {
                     result.invalidType(location, pathName, "object", pathValue);
                 } else {
+                    if(!pathName.startsWith("/")){
+                        result.warning(location," Resource "+pathName+ " should start with /");
+                    }
                     ObjectNode path = (ObjectNode) pathValue;
                     PathItem pathObj = getPathItem(path,String.format("%s.'%s'", location,pathName), result);
                     paths.put(pathName, pathObj);
@@ -2682,6 +2685,7 @@ protected static class ParseResult {
         private Map<Location, JsonNode> unsupported = new LinkedHashMap<>();
         private Map<Location, String> invalidType = new LinkedHashMap<>();
         private List<Location> missing = new ArrayList<>();
+        private List<Location> warnings = new ArrayList<>();
         private List<Location> unique = new ArrayList<>();
         private List<Location> uniqueTags = new ArrayList<>();
 
@@ -2699,9 +2703,14 @@ public void extra(String location, String key, JsonNode value) {
         public void missing(String location, String key) {
             missing.add(new Location(location, key));
         }
-
+      
+        public void warning(String location, String key) {
+            warnings.add(new Location(location, key));
+        }
+      
         public void unique(String location, String key) {
             unique.add(new Location(location, key));
+
         }
 
         public void uniqueTags(String location, String key) {uniqueTags.add(new Location(location,key));}
@@ -2735,6 +2744,11 @@ public List<String> getMessages() {
                 String message = "attribute " + location + l.key + " is missing";
                 messages.add(message);
             }
+            for (Location l : warnings) {
+                String location = l.location.equals("") ? "" : l.location + ".";
+                String message = "attribute " + location +l.key;
+                messages.add(message);
+            }
             for (Location l : unsupported.keySet()) {
                 String location = l.location.equals("") ? "" : l.location + ".";
                 String message = "attribute " + location + l.key + " is unsupported";

modules/swagger-parser/src/test/java/io/swagger/parser/OpenAPIParserTest.java

@@ -75,6 +75,15 @@ public void testIssue887() {
         assertEquals(result.getMessages().get(0), "attribute tags.sample is repeated");
     }
 
+    @Test
+    public void testIssue892() {
+        SwaggerParseResult result = new OpenAPIParser().readLocation("issue892-main.yaml", null, null);
+
+        assertEquals(result.getMessages().size(),1);
+        assertNotNull(result.getOpenAPI());
+        assertEquals(result.getOpenAPI().getOpenapi(), "3.0.1");
+    }
+
     @Test
     public void testIssue768() {
         ParseOptions options = new ParseOptions();

modules/swagger-parser/src/test/resources/issue892-main.yaml

@@ -0,0 +1,22 @@
+openapi: 3.0.1
+info:
+  title: ping test
+  version: '1.0'
+servers:
+  - url: 'http://localhost:8000/'
+paths:
+  some/ping:
+    get:
+      operationId: pingGet
+      parameters:
+        - name: i
+          in: query
+          description: Test
+          required: true
+          schema:
+            $ref: './issue749-reference.yaml#/SomeId'
+      responses:
+        '201':
+          description: OK
+components:
+  schemas: {}