feat(evaluate): add support for Map/Set realm#15
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Map/Set evaluation by introducing a new evaluation realm that handles Map and Set instances, and updates tests and documentation accordingly.
- Introduces MapSetEvaluationRealm to enable JSON Pointer evaluation on Map and Set objects.
- Adds comprehensive test cases in test/evaluate/realms/map-set.js.
- Updates README.md to document the new Map/Set Evaluation Realm.
- Updates test/evaluate/index.js for consistency with RFC 6901 naming and improved testing practices.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/evaluate/realms/map-set.js | Implements evaluation logic specifically for Map and Set objects. |
| test/evaluate/realms/map-set.js | Adds tests covering various JSON Pointer evaluation scenarios for Map/Set. |
| README.md | Documents the usage and functionality of the new Map/Set Evaluation Realm. |
| test/evaluate/index.js | Refactors test descriptions and imports to align with updated standards. |
Comments suppressed due to low confidence (1)
test/evaluate/realms/map-set.js:79
- The test description mentions an array while the expected return value is a Set. Consider updating the description to accurately describe the return type as a Set.
specify('should return array ["bar", "baz"] for "/foo"', function () {
Member
Author
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #13