Skip to content

feat(evaluate): add support for minim realm#17

Merged
char0n merged 1 commit intomainfrom
char0n/13-minim
Mar 20, 2025
Merged

feat(evaluate): add support for minim realm#17
char0n merged 1 commit intomainfrom
char0n/13-minim

Conversation

@char0n
Copy link
Member

@char0n char0n commented Mar 20, 2025

Refs #13

@char0n char0n requested a review from Copilot March 20, 2025 08:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the Minim Evaluation Realm, enabling JSON Pointer evaluation on Minim data structures. The changes include a new MinimEvaluationRealm implementation and TypeScript definitions, updates to related tests and documentation, and an update to the JSONPointerKeyError error handling.

  • Adds MinimEvaluationRealm in JavaScript to handle ObjectElement and ArrayElement.
  • Provides TypeScript definitions for the realm.
  • Updates unit tests, documentation, and error messaging in evaluation logic.

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/evaluate/realms/minim.js Implements MinimEvaluationRealm with evaluation, type checking, and size functions for Minim elements.
types/evaluate/realms/minim.ts Adds TypeScript definitions for MinimEvaluationRealm.
test/evaluate/realms/minim.js Introduces unit tests for MinimEvaluationRealm functionality.
README.md Updates documentation to include Minim Evaluation Realm usage.
src/errors/JSONPointerKeyError.js Removes custom error message generation by simplifying the class.
test/evaluate/realms/map-set.js Removes duplicate valid pointer tests.
test/evaluate/index.js Removes duplicate valid pointer tests.
src/evaluate/index.js Updates the thrown error message for missing object keys.
Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (1)

src/evaluate/realms/minim.js:19

  • The sizeOf method returns node.length for both arrays and objects, while objects are later processed via node.keys(). Verify that ObjectElement defines a length property to accurately measure its size.
return node.length;

@char0n char0n merged commit 7a15f7e into main Mar 20, 2025
4 checks passed
@char0n char0n deleted the char0n/13-minim branch March 20, 2025 09:01
char0n pushed a commit that referenced this pull request Mar 20, 2025
# [1.6.0](v1.5.0...v1.6.0) (2025-03-20)

### Features

* **evaluate:** add support for minim realm ([#17](#17)) ([7a15f7e](7a15f7e)), closes [#13](#13)
@char0n
Copy link
Member Author

char0n commented Mar 20, 2025

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants