Open
Conversation
|
When is this gonna be merged? |
|
I think this is a fairly common thing and should be looked at. Think matrices, csv, etc., nested arrays are not that uncommon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Add a nested array parser for an array of array examples. To achieve this, the example string is parsed into a tree and then the tree structure is converted to an array of arrays. "{" and "}" are chosen to specify the nested array beginning and end but this can easily be changed. An example of a nested array example is:
{{one,two},{three,four}}. This implementation is backward compatible with arrays. The example could be "{one,two}" as well as "one,two"Relation issue
#1041
Additional context
For an extensive fix, depth in ComplementSchema should be a variable instead of constant 2.