fix: swag fmt not working with relative path like ../#2117
Open
shindonghwi wants to merge 1 commit intoswaggo:masterfrom
Open
fix: swag fmt not working with relative path like ../#2117shindonghwi wants to merge 1 commit intoswaggo:masterfrom
shindonghwi wants to merge 1 commit intoswaggo:masterfrom
Conversation
The excludeDir function incorrectly treated ".." as a hidden folder because it checked if the path starts with "." and has length > 1. This caused `swag fmt --dir ../` to skip the parent directory entirely. Fixes swaggo#2112
|
Push |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
swag fmt --dir ../not formatting files when using relative parent pathexcludeDirfunction incorrectly treated..as a hidden folder because it checked if path starts with.and has length > 1Changes
..from being treated as hiddenFixes #2112