fix: prevent overwriting schema format with empty values#2155
Open
celaldurmusoglu wants to merge 2 commits intoswaggo:masterfrom
Open
fix: prevent overwriting schema format with empty values#2155celaldurmusoglu wants to merge 2 commits intoswaggo:masterfrom
celaldurmusoglu wants to merge 2 commits intoswaggo:masterfrom
Conversation
Add structured Override type to replace raw string overrides, enabling nullable, format, and other schema attributes to be specified alongside the type name when overriding generic placeholders (e.g. $T). Key changes: - Override struct with Type, Nullable, and Format fields - matchOverride() for comparing type names against overrides - getOverrideForType() to find matching overrides for a given type - applyOverrideAttrs() to apply nullable/format attributes to schemas - parseOverrides() in gen.go with key:value attribute parsing syntax - Comprehensive tests for all new functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
fix: prevent overwriting schema format with empty values
Relation issue
Related PR: #2148
Additional context
Ensure that schema format is not overwritten when override attributes contain empty values.
This preserves the original format in the generated schemas and prevents unintended changes.