fix: resolve get_normalized_dict() returning empty for V3 endpoints #606
+171
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for V3 endpoints with custom parsers in get_normalized_dict() and get_normalized_json() methods. Previously, these methods only handled legacy format (resultSets/resultSet) and returned empty dictionaries for V3 endpoints like BoxScoreTraditionalV3. Changes: - Store endpoint name in NBAStatsResponse when get_data_sets() is called - Update get_normalized_dict() to use parser for V3 endpoints - Convert parsed V3 data to normalized format (list of dicts) - Add comprehensive unit tests for normalized methods Fixes swar#602
Remove all inline comments and docstrings from the V3 endpoint normalization implementation and associated unit tests to improve code readability and reduce clutter.
swar
reviewed
Jan 9, 2026
| def __init__(self, *args, **kwargs): | ||
| super().__init__(*args, **kwargs) | ||
| self._endpoint = None | ||
|
|
Owner
There was a problem hiding this comment.
What's the intention behind self._endpoint?
Owner
|
Overall this code seems fine. We'll just want test it out and ensure it's working. I do have a comment in the code as I'm trying to understand the need for adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #602
This PR resolves the issue where
get_normailized*methods return empty values.Notebook Demonstrating Fix
Root Cause:
Solution
Added V3 endpoint support to the normalization pipeline in src/nba_api/stats/library/http.py:
context for normalization
keys)
endpoint is stored
Testing
Created new unit tests and all existing tests pass.