fix(parameters): add NBA Cup and IST season type constants (#620) #625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nba_cupandistconstants toSeasonTypeparameter classIssue
Fixes #620
Background
Users reported that 'IST' season type works with PlayerGameLogs but not TeamDashLineups. The underlying issue was that these season types (NBA Cup/IST) were not available as named constants in the library, forcing users to use raw string literals.
Changes
src/nba_api/stats/library/parameters.py: Added two new attributes toSeasonTypebase classnba_cup = "NBA Cup"ist = "IST"tests/unit/test_parameters.py: Updated 6 test functions to assert new attributes exist and have correct valuesTesting
Usage Example