Always show errors in robot log, instead of treating them as ephemeral#2695
Merged
mergify[bot] merged 1 commit intomainfrom Mar 6, 2026
Merged
Always show errors in robot log, instead of treating them as ephemeral#2695mergify[bot] merged 1 commit intomainfrom
mergify[bot] merged 1 commit intomainfrom
Conversation
Fixes #2227. Partially reverts #1877. The motivation for #1877 was largely because of errors being shown by the `run` command, when the `.sw` file being loaded did not parse or type check. Such errors could be quite large, and were irrelevant once the `.sw` file had been fixed, so making them "ephemeral" worked very well. However, with #2540 and #2679 `run` has now been replaced by `import`, which generates not *runtime* errors but *compile-time* errors. Such errors are shown in the REPL console rather than a robot log, so the original motivation for #1877 is now moot. The remaining runtime errors tend to be short (*e.g* "move: There is a mountain in the way!") and potentially relevant to see in the log history, so making them ephemeral does not make as much sense.
xsebek
approved these changes
Mar 6, 2026
Contributor
Merge Queue StatusRule:
This pull request spent 5 seconds in the queue, with no time running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2227. Partially reverts #1877.
The motivation for #1877 was largely because of errors being shown by the
runcommand, when the.swfile being loaded did not parse or type check. Such errors could be quite large, and were irrelevant once the.swfile had been fixed, so making them "ephemeral" worked very well. However, with #2540 and #2679runhas now been replaced byimport, which generates not runtime errors but compile-time errors. Such errors are shown in the REPL console rather than a robot log, so the original motivation for #1877 is now moot. The remaining runtime errors tend to be short (e.g "move: There is a mountain in the way!") and potentially relevant to see in the log history, so making them ephemeral does not make as much sense.