Skip to content

feat(core): respect decoratorVersion config #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2025
Merged

feat(core): respect decoratorVersion config #956

merged 1 commit into from
Aug 17, 2025

Conversation

Brooooooklyn
Copy link
Member

@Brooooooklyn Brooooooklyn merged commit 2dcaa95 into master Aug 17, 2025
16 checks passed
@Brooooooklyn Brooooooklyn deleted the respect-decorator-versions branch August 17, 2025 12:52
@MuTsunTsai
Copy link

No, this doesn't really close #939 nor #773, for a few reasons:

  1. It assigns parser.decorators to Boolean(opts.experimentalDecorators), which is wrong. It should be true always. Doing it the other way will make decorators available only for the legacy experimental decorators.
  2. It assings transform.decoratorVersion to opts.decoratorVersion, but the latter was never assigned in tsCompilerOptionsToSwcConfig so the whole thing just doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brooooooklyn @MuTsunTsai