fix(hstr): Skip only \u for unicode
#11216
Merged
+143
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1344aef The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Binary Sizes
Commit: e1d6c21 |
CodSpeed Performance ReportMerging #11216 will not alter performanceComparing Summary
|
Member
|
cc @h-a-n-a Can you take a look? Does this look correct? |
Member
|
Also, FYI, AI created #11217 |
Contributor
Looks like this is a correct implementation. I made a mistake in the previous PR |
kdy1
changed the title
\u for unicode
kdy1
pushed a commit
that referenced
this pull request
Nov 5, 2025
**Description:** Attempt to fix #11214. The reason for unespaced `\\` was special handling for unicode `\u` codepoint, that escapes any string literal starts with `\u` - for windows, path separator with u (`\\u`) matches with this case. PR attempts to solve by lookahead, confirming all 4 following char is hex digit to represent unicode hex, otherwise consider it as plain string. To be honest I'm not sure if this is acceptable approach or not, feel free to close if there's better way to fix. **Related issue:** - Closes #11214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Attempt to fix #11214.
The reason for unespaced
\\was special handling for unicode\ucodepoint, that escapes any string literal starts with\u- for windows, path separator with u (\\u) matches with this case.PR attempts to solve by lookahead, confirming all 4 following char is hex digit to represent unicode hex, otherwise consider it as plain string. To be honest I'm not sure if this is acceptable approach or not, feel free to close if there's better way to fix.
BREAKING CHANGE:
Related issue (if exists):
#11214