Skip to content

Conversation

@swhitty
Copy link
Owner

@swhitty swhitty commented Apr 17, 2025

Convert the top level types KeyValueEncoder and KeyValueDecoder from class to struct so they can easily become Sendable without adding a lock.

While this is a API change breaking change the fixit is easy convert let decoder to var decoder where required.

Only code that adjusts the decoding strategies will be impacted.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.88%. Comparing base (45154f9) to head (2f9f5bd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files           3        3           
  Lines         891      891           
=======================================
  Hits          890      890           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@swhitty swhitty merged commit 6b0dc95 into main Apr 17, 2025
12 checks passed
@swhitty swhitty deleted the struct-sendable branch April 17, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants