Skip to content

Make public class public constructable #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2020
Merged

Make public class public constructable #154

merged 1 commit into from
Jan 19, 2020

Conversation

krzyzanowskim
Copy link
Contributor

HTTPClientCopyingDelegate meant to be public, hence make the initializer public.

@swift-server-bot
Copy link

Can one of the admins verify this patch?

2 similar comments
@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@krzyzanowskim krzyzanowskim changed the title Make public class public contrictible Make public class public constructable Jan 19, 2020
@krzyzanowskim krzyzanowskim requested a review from Lukasa January 19, 2020 11:39
@weissi weissi requested a review from artemredkin January 19, 2020 20:13
weissi
weissi approved these changes Jan 19, 2020
View reviewed changes
Copy link
Contributor

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, @artemredkin ?

@artemredkin
Copy link
Collaborator

Looks good, thank you!

@Lukasa
Copy link
Collaborator

Lukasa commented Jan 19, 2020

@swift-server-bot test this please

@Lukasa Lukasa merged commit d5aa3a1 into swift-server:master Jan 19, 2020
@weissi weissi added the 🆕 semver/minor Adds new public API. label Jan 19, 2020
@weissi weissi added this to the 1.1.0 milestone Jan 19, 2020
@Lukasa Lukasa mentioned this pull request Jan 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemredkin artemredkin artemredkin approved these changes

@weissi weissi weissi approved these changes

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@krzyzanowskim @swift-server-bot @artemredkin @Lukasa @weissi