Skip to content

Add head property to FileDownloadDelegate's Progress/Response struct #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 18, 2025
Merged

Add head property to FileDownloadDelegate's Progress/Response struct #811

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
23682ac
add `responseHead` to `FileDownloadDelegate.Progress`
gregcotten Feb 13, 2025
6edf1e7
rename `responseHead` to `head`
gregcotten Feb 13, 2025
82e74b9
init `head` with bogus data
gregcotten Feb 14, 2025
7433b55
add `FileDownloadDelegate.Response` `head` to existing tests
gregcotten Feb 14, 2025
601b2e4
fix XCTAssertEqual order for cohesion
gregcotten Feb 14, 2025
a73edf5
FileDownloadDelegate.Progress -> Response
gregcotten Feb 14, 2025
32751ce
project `_head` optional via `head`
gregcotten Feb 17, 2025
16a67ba
use assert for _head nil check, use self
gregcotten Feb 17, 2025
484f55e
format error
gregcotten Feb 17, 2025
448097a
Merge branch 'main' into download-response-add-head
gregcotten Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Sources/AsyncHTTPClient/FileDownloadDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@ public final class FileDownloadDelegate: HTTPClientResponseDelegate {
public struct Progress: Sendable {
public var totalBytes: Int?
public var receivedBytes: Int
public var head: HTTPResponseHead!
}

private var progress = Progress(totalBytes: nil, receivedBytes: 0)
private var progress = Progress(totalBytes: nil, receivedBytes: 0, head: nil)

public typealias Response = Progress

Expand Down Expand Up @@ -135,6 +136,8 @@ public final class FileDownloadDelegate: HTTPClientResponseDelegate {
) -> EventLoopFuture<Void> {
self.reportHead?(task, head)

self.progress.head = head

if let totalBytesString = head.headers.first(name: "Content-Length"),
let totalBytes = Int(totalBytesString)
{
Expand Down