Add swift-configuration support #878
Open
+632
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czechboy0
reviewed
Jan 8, 2026
Sources/AsyncHTTPClient/HTTPClientConfiguration+SwiftConfiguration.swift
Show resolved
Hide resolved
| public init(configReader: ConfigReader) throws { | ||
| self.init() | ||
|
|
||
| // Each entry in the list should be a colon separated pair e.g. localhost:127.0.0.1 or localhost:::1 |
Contributor
Author
There was a problem hiding this comment.
colon felt more natural to me for defining key-value pairs. I don't mind though
Contributor
Author
There was a problem hiding this comment.
comma would probably make the ipv6 case slightly eaiser to parse too
There was a problem hiding this comment.
Oh right, comma might be used for splitting the pairs themselves e.g. in env vars. Hmm then comma isn't great, but colon is a bit confusing.
|
lgtm, I'll let the maintainers actually approve though 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users should be able to use swift-configuration to create the http client configuration object
Changes