[CI] Set Swift 6 container image for API breakage + Documentation check #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or API breakage and documentation checks.
fabianfett
approved these changes
Aug 29, 2024
|
Even though docs doesn't work currently, let's get this merged so that API breakage check works again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently, the API Breakage and Documentation checks are failing since these checks run on the
swift:5.10-nobleimage while the library requires Swift 6.With the new container image parameters introduced in apple/swift-nio#2851, the image for the API Breakage and Documentation checks can be configured to
swiftlang/swift:nightly-6.0-jammy.Modifications:
Set the
api_breakage_check_container_imageanddocs_check_container_imageparameters toswiftlang/swift:nightly-6.0-jammy.Result:
The API Breakage and Documentation checks will no longer immediately fail.