Skip to content

fix local deps in plugin #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2024
Merged

fix local deps in plugin #389

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fdbd36
fix local deps in plugin
sebsto Oct 8, 2024
c497140
swift format
sebsto Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Plugins/AWSLambdaPackager/Plugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,15 +128,15 @@ struct AWSLambdaPackager: CommandPlugin {
print("building \"\(product.name)\"")
let buildCommand =
"swift build -c \(buildConfiguration.rawValue) --product \(product.name) --static-swift-stdlib"
if ProcessInfo.processInfo.environment["LAMBDA_USE_LOCAL_DEPS"] != nil {
if let localPath = ProcessInfo.processInfo.environment["LAMBDA_USE_LOCAL_DEPS"] {
// when developing locally, we must have the full swift-aws-lambda-runtime project in the container
// because Examples' Package.swift have a dependency on ../..
// just like Package.swift's examples assume ../.., we assume we are two levels below the root project
let slice = packageDirectory.pathComponents.suffix(2)
try Utils.execute(
executable: dockerToolPath,
arguments: [
"run", "--rm", "--env", "LAMBDA_USE_LOCAL_DEPS=true", "-v",
"run", "--rm", "--env", "LAMBDA_USE_LOCAL_DEPS=\(localPath)", "-v",
"\(packageDirectory.path())../..:/workspace", "-w",
"/workspace/\(slice.joined(separator: "/"))", baseImage, "bash", "-cl", buildCommand,
],
Expand Down
Loading