Skip to content

[core] Remove platform dance in Package.swift #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 19, 2024
Merged

[core] Remove platform dance in Package.swift #400

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ea009a
Remove platform dance in Package.swift
fabianfett Oct 9, 2024
18eabfc
Merge branch 'main' into ff-platform-dance
sebsto Oct 11, 2024
3c5d217
Merge branch 'main' into ff-platform-dance
sebsto Nov 26, 2024
b27a98a
Merge branch 'main' into ff-platform-dance
sebsto Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NOTICE.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ components that this product depends on.
-------------------------------------------------------------------------------


This product contains a derivation various scripts from SwiftNIO.
This product contains a derivation various code and scripts from SwiftNIO.

* LICENSE (Apache License 2.0):
* https://www.apache.org/licenses/LICENSE-2.0
Expand Down
8 changes: 1 addition & 7 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,9 @@

import PackageDescription

#if os(macOS)
let platforms: [PackageDescription.SupportedPlatform]? = [.macOS(.v15)]
#else
let platforms: [PackageDescription.SupportedPlatform]? = nil
#endif

let package = Package(
name: "swift-aws-lambda-runtime",
platforms: platforms,
platforms: [.macOS(.v15)],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the Swift 6 nightly and swift 6 language mode CI actions

/__w/swift-aws-lambda-runtime/swift-aws-lambda-runtime/Package.swift:7:25: error: reference to member 'v15' cannot be resolved without a contextual type
  5 | let package = Package(
  6 |     name: "swift-aws-lambda-runtime",
  7 |     platforms: [.macOS(.v15)],
    |                         `- error: reference to member 'v15' cannot be resolved without a contextual type
  8 |     products: [
  9 |         // this library exports `AWSLambdaRuntimeCore` and adds Foundation convenience methods

products: [
// this library exports `AWSLambdaRuntimeCore` and adds Foundation convenience methods
.library(name: "AWSLambdaRuntime", targets: ["AWSLambdaRuntime"]),
Expand Down
Loading