Update rdkafka #186
Closed
Update rdkafka #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were a few releases behind. This gets us up to 2.8.0
FranzBusch
force-pushed
the
fb-update-rdkafka
branch
from
6b30249 to
093ac08
Compare
0xTim
approved these changes
Feb 18, 2025
mimischi
added a commit
to mimischi/swift-kafka-client
that referenced
this pull request
Feb 20, 2025
Updates `librdkafka` to the latest release 2.8.0. A recent commit* added a function call that is not available in BoringSSL. This requires us moving away from BoringSSL again. `libssl-dev` now needs to be available during build time again. * https://github.com/confluentinc/librdkafka/blame/93877617709eb071a0f4ec7038c54e2764abefc9/src/rdkafka_ssl.c#L1533 Closes swift-server#186
mimischi
added a commit
that referenced
this pull request
Feb 24, 2025
Updates `librdkafka` to the latest release 2.8.0. ### Motivation: The `librdkafka` version shipped by this client has gotten fairly old, and there's been a few releases with bug fixes. ### Modifications: A recent commit [1] added a function call that is not available in BoringSSL. This requires us moving away from BoringSSL again. [1] https://github.com/confluentinc/librdkafka/blame/93877617709eb071a0f4ec7038c54e2764abefc9/src/rdkafka_ssl.c#L1533 ### Result: * Updated `librdkafka` to 2.8.0. * Removed BoringSSL from project (introduced in #135) * `libssl-dev` now needs to be available during build time again. Closes #186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were a few releases behind. This gets us up to 2.8.0