Skip to content

Enable strict concurrency #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2024
Merged

Enable strict concurrency #119

merged 1 commit into from
Dec 12, 2024

Conversation

czechboy0
Copy link
Contributor

Summary

Catch potential data races at build time.

  • Enabled strict concurrency checking in the Package.swift.
  • The package is warning-free with this setting out of the box, so no action.

Test Plan

Verified no warnings and tests pass locally on macOS, and then on Linux with 5.9, 5.10, and 6.0

@czechboy0 czechboy0 added the semver/none No version bump required. label Dec 12, 2024
@czechboy0 czechboy0 enabled auto-merge (squash) December 12, 2024 13:03
@czechboy0 czechboy0 merged commit 06a06bd into swift-server:main Dec 12, 2024
22 of 23 checks passed
@czechboy0 czechboy0 deleted the hd-strict-concurrency branch December 12, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gjcairo gjcairo gjcairo approved these changes

Assignees

No one assigned

Labels

semver/none No version bump required.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@czechboy0 @gjcairo