Push 'Add Benchmarks for metrics #106' over the finish line #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_and_increment_.p90.json
Co-authored-by: Rick Newton-Rogers <[email protected]>
rnro
approved these changes
Aug 26, 2025
There was a problem hiding this comment.
The benchmarks look good!
The only thing I note is that the minimum tools version is 5.9 (outside of the normal Swift on Server support matrix) whereas the thresholds are only defined from 5.10. Probably for a different PR but that version may want to be bumped.
|
Good point, we can bump minimum to 5.10 indeed, that's the "three versions back" we support |
FranzBusch
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to take Add Benchmarks for metrics #106 over the finish line; just some minor things were pending