Make logging optional and update docs #189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! 👋 This PR contains a few changes, notably:
README.md
to use the new initializer instead of the deprecated one.renamed
to the deprecated initializer.logging
parameter on the initializers optional, the motivation for this is in cases the user don't or can't do logging, they don't have to construct a logger and bootstrap the logging system withSwiftLogNoOpLogHandler
, so this code:becomes
and it also allows the user to do logging outside the ServiceGroup without necessarily doing logging within it.
If there is anything to improve, let me know! 😃
thanks dimi and gwynne for helping along the way and answering my questions :)