Include the service name in the serviceFinishedUnexpectedly error
#217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
force-pushed
the
fb-service-error
branch
from
95dda8f to
2b1f028
Compare
czechboy0
approved these changes
Oct 7, 2025
## Motivation To aid debugging and troubleshooting, it is helpful to understand which Service led to the error. ## Modifications Add the service name to the `serviceFinishedUnexpectedly` error. ## Result Easier to debug failing services.
FranzBusch
force-pushed
the
fb-service-error
branch
from
2b1f028 to
d167a4b
Compare
|
Thank you for filing and fixing this. |
|
Merging over the API break since this is actually an ABI break |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
## Motivation
To aid debugging and troubleshooting, it is helpful to understand which Service led to the error.
Modifications
Add the service name to the
serviceFinishedUnexpectedlyerror.Result
Easier to debug failing services.